Add Booking Facility on Single-Room Page #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"TypeError: ews.TimeSpan.FromHours(...).asMilliseconds is not a function"
room.appointments.length my not be loaded in time. Try-Catch typeerror reloads the page if it catches this error.
Added buttons on the room screen to book, extend, cancel and book after current meeting. Added button on the room screen to go back to the flightboard. This is made visible depending on a variable in the .env file Added a logo to the room screen. Added option to hide the drop down on the flight board screen. This is made visible depending on a variable in the .env file Auth.js has been moved to ./config/auth/auth.js - this move creates an option to mount the folder in RAM making the auth.js file temporary. On my own build I've encrypted auth.js and at boot if certain criteria are met, it is unencrypted and copied a ram mounted drive named auth linked to the config folder
bikkimahato
reviewed
Jan 8, 2022
app/ews/roombooking.js
Outdated
| exch.Credentials = new ews.WebCredentials(auth.exchange.username, auth.exchange.password); | ||
| exch.Url = new ews.Uri(auth.exchange.uri); | ||
| //ews.EwsLogging.DebugLogEnabled = true; | ||
| if ((bookingType == 'BookNow') || (bookingType == 'BookAfter')){ |
There was a problem hiding this comment.
Please use strict equality operator ===
bikkimahato
reviewed
Jan 8, 2022
app/ews/roombooking.js
Outdated
| console.log(err); | ||
| }); | ||
| } | ||
| else if ((bookingType == 'Extend') || (bookingType == 'EndNow')){ |
There was a problem hiding this comment.
Please use strict equality operator ===
There was a problem hiding this comment.
Thanks for the heads up! Will change all of these now.
app/ews/roombooking.js
Outdated
| console.log(start); | ||
| var apptStartewsDT = new ews.DateTime(new Date(parseInt(start, 10))); | ||
| var apptStartTime = moment(start).toISOString(); | ||
| if (apptStartTime == startTime){ |
There was a problem hiding this comment.
Please use strict equality operator ===
Comment on lines
26
to
29
| //console.log("Window.location.reload"); | ||
| //console.log(this.state.currentError); | ||
| // if (this.state.currentError == TypeError){ | ||
| // console.log("TYPE ERROR") |
replaced equality operator == with strict equality operator ===
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a few buttons on the single room page that post back to a script in the EWS folder booking that particular room. Buttons are modular and only display if the room is free for that time. I've added an extend function if the room is currently busy, however it books the room after the current meeting rather than actually extending the meeting, I'll see if it can be updated to extend the meeting rather than book a new one at a later stage.