Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better yml to xliff script #1

Closed
wants to merge 1 commit into from

Conversation

wouterj
Copy link

@wouterj wouterj commented Aug 3, 2013

I created a script which takes care of some CS things that the current script doesn't. This is a placeholder, will submit the script soon

@wouterj
Copy link
Author

wouterj commented Aug 3, 2013

@dantleech code attached. If you agree, you can merge it.

For an example of the output, see symfony-cmf/blog-bundle#30

@dantleech
Copy link
Owner

hmm, I'd rather not add an opaque phar archive. This is really just intended to be a personal collection of hackable scripts. Are there lots of deps?

@wouterj
Copy link
Author

wouterj commented Aug 3, 2013

it's using the Yaml component (for better yaml parsing) and the console component. The console component can be removed, but imo the Yaml component is needed to make sure it's parsed well.

@dantleech
Copy link
Owner

Still, not sure I like having binaries - it essentially means its not
easily modifiable or diffable. This repo was intended to be more a
collection of single-use hacks that might be reused.

Maybe if you add a /bin directory and we can put it in there? As I guess
this is more about convenience than having an official repository.

On Sat, Aug 03, 2013 at 05:16:21AM -0700, Wouter J wrote:

it's using the Yaml component (for better yaml parsing) and the console
component. The console component can be removed, but imo the Yaml
component is needed to make sure it's parsed well.


Reply to this email directly or [1]view it on GitHub.

References

Visible links

  1. Better yml to xliff script #1 (comment)

@wouterj
Copy link
Author

wouterj commented Aug 3, 2013

I agree with you. We can also remove the console component en copy/past the Parser class of the Yaml component in the php script.

Or I can try to fix the issues with your script. Just let me know what you want and I'll see if I can do it.

@dantleech
Copy link
Owner

Or.. just put it in a new directory with the composer.json, or even with
a simple buildscript to make the phar. It doesn't really matter if we
have to type "composer install" once or "make" before using it

btw what are the issues with my script? (apart from the way it sets the
attribute "original")

On Sat, Aug 03, 2013 at 05:35:10AM -0700, Wouter J wrote:

I agree with you. We can also remove the console component en copy/past
the Parser class of the Yaml component in the php script.

Or I can try to fix the issues with your script. Just let me know what you
want and I'll see if I can do it.


Reply to this email directly or [1]view it on GitHub.

References

Visible links

  1. Better yml to xliff script #1 (comment)

@wouterj wouterj closed this Dec 25, 2013
@wouterj wouterj deleted the betteryml_to_xliff branch December 25, 2013 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants