set version for moduletest #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xendk
approved these changes
Sep 5, 2024
spaceo
reviewed
Sep 5, 2024
| @@ -70,6 +70,7 @@ sites: | |||
| description: "The library site for Aarhus" | |||
| deploy_key: "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFL+uMeEfsaHEzbNxOmBB8dX32OLo63CTomG8VZvuiN2" | |||
| plan: webmaster | |||
| moduletest-dpl-cms-release: "2024.35.1" | |||
There was a problem hiding this comment.
Since the moduletest-dpl-cms-release version equals the default version why not using only the default version and delete the moduletest-dpl-cms-release version until it differs in the future?
There was a problem hiding this comment.
you're right. Last week i had to do it a little fast, so that's why i did it like this
ITViking
force-pushed
the
add-module-version
branch
from
c6e633e to
9747c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
set the moduletest environments version
Should this be tested by the reviewer and how?
Just read it
Any specific requests for how the PR should be reviewed?
No
What are the relevant tickets?
https://reload.atlassian.net/jira/software/c/projects/DDFDRIFT/boards/464?selectedIssue=DDFDRIFT-200