Set resource req in all the desired pods in the wanted namespaces #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperg
reviewed
Jul 16, 2024
ITViking
changed the base branch from
main
to
seperate-versions-between-moduletest-and-main
ITViking
changed the base branch from
seperate-versions-between-moduletest-and-main
to
main
ITViking
force-pushed
the
set-resource-req-in-postrollouttask
branch
from
ff600d2 to
fb12e0b
Compare
|
@kasperg vil du give denne her et kig mere? |
kasperg
reviewed
Aug 14, 2024
kasperg
reviewed
Aug 14, 2024
| @@ -7,6 +7,11 @@ FROM uselagoon/php-8.1-cli-drupal:${LAGOON_IMAGES_RELEASE_TAG} | |||
|
|
|||
| COPY --from=release /app /app | |||
| RUN mkdir -p -v -m775 /app/web/sites/default/files | |||
| # install kubectl - we need as long as we cant set the resource request | |||
There was a problem hiding this comment.
Appreciate you mentioning why this is needed.
added 9 commits
August 15, 2024 13:58
ITViking
force-pushed
the
set-resource-req-in-postrollouttask
branch
from
15e4076 to
c9b3ce2
Compare
kasperg
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adjusts the memory requests for the pods: cli, nginx, varnish and redis. This should help kubernetes to better allocate workloads
Should this be tested by the reviewer and how?
This can be run without any concerns. Please do so.
Any specific requests for how the PR should be reviewed?
Test run it and read it through
What are the relevant tickets?
https://reload.atlassian.net/jira/software/c/projects/DDFDRIFT/boards/464?selectedIssue=DDFDRIFT-96