Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide adjustments #241

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Guide adjustments #241

merged 2 commits into from
Mar 27, 2024

Conversation

hypesystem
Copy link
Contributor

@hypesystem hypesystem commented Mar 7, 2024

Draft because this is WIP as we run through runbooks and try to use them.

  • Lagoon ssh keys as a prerequisite now also list where to create those keys
  • When creating a site, a git-url must be provided - it is now clarified that the repo it points to does not need to exist before running the tasks in the runbook.

Should this be tested by the reviewer and how?

Read and verify the changes improve clarity, while staying as concise as possible.

What are the relevant tickets?

N/A

…of the developer

- Lagoon ssh keys as a prerequisite now also list where to create those keys
- When creating a site, a git-url must be provided - it is now clarified that the repo it points to does not need to exist before running the tasks in the runbook.
@hypesystem hypesystem changed the title Adjustments to prerequisites for guides clarifying what they require of the developer Guide adjustments Mar 11, 2024
@hypesystem hypesystem marked this pull request as ready for review March 14, 2024 10:19
@hypesystem hypesystem requested review from kasperg and spaceo March 14, 2024 10:20
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hypesystem hypesystem merged commit 097e631 into main Mar 27, 2024
3 checks passed
@hypesystem hypesystem deleted the guide-adjustments-2024-03 branch March 27, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants