Handle graphql consumers for both BNF and Go #1891
Conversation
Since we introduced an object oriented way of handling consumers, users and roles, we do not need these files anymore
So they align with the created entities
and use consumer handler for entity deletion as well.
To avoid confusion we handle consumers and users in one place
Since the whole consumer/user/role part was refactored we also need to adjust the drush commands handling secrets/uuids
Adjust cmds to fit new way of handling consumers and be more specific about what each command actually is doing.
…brugeren-kun-bliver-oprettet-i-dpl-consumers-deploy-hook
| * | ||
| * This class is responsible for creating consumers and users. | ||
| */ | ||
| class ConsumerHandler { |
There was a problem hiding this comment.
I'm not fond of this class. What is a "ConsumerHandler" anyway?
On one hand it's a composition of consumer, user and role. On the other hand setComponents allows for setting new consumer, user and role.
In my mind it should either be a "handler", state free, and having create and delete just take the consumer, user and role as arguments.
Or it should be an object representing this combination (ConsumerSetup perhaps?), in which case it should take consumer, user and role as constructor arguments (and then you'd need a factory in order to get the container to inject the logger).
| // Delete consume and users that we want to handle differently. | ||
| // We want to create consumers and consumer users | ||
| // specifically for the two known consumers (BNF and Go) and connected users. | ||
| (new Consumer("graphql_consumer", \Drupal::entityTypeManager()))->delete(); |
There was a problem hiding this comment.
Maybe ConsumerHandler should have methods for getting Consumer and ConsumerUser so the DI can be passed to it? Having to create a repository service for each of them is a bit overkill, but I think having to pass entityTypeManager to each new is a bit of a DX wart.
Since our deploy hook takes care of that now
My reviewer did not like setting the components as properties of the handler.
In order to inject dependencies (right now entityTypeManager) into the consumer components (Consumer, ConsumerUser).
spaceo
force-pushed
the
DDFBRA-290-sorg-for-at-graph-ql-consumer-brugeren-kun-bliver-oprettet-i-dpl-consumers-deploy-hook
branch
from
34c8d7e to
2548ce1
Compare
spaceo
deleted the
DDFBRA-290-sorg-for-at-graph-ql-consumer-brugeren-kun-bliver-oprettet-i-dpl-consumers-deploy-hook
branch
Link to issue
https://reload.atlassian.net/browse/DDFBRA-290
Description
This PR handles: