Skip the /admin/update/ready page #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperg
approved these changes
Dec 20, 2024
web/modules/custom/dpl_webmaster/src/Form/InstallOrUpdateModule.php
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_webmaster/src/Form/InstallOrUpdateModule.php
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_webmaster/src/Form/InstallOrUpdateModule.php
Outdated
Show resolved
Hide resolved
The page suggests backing up the site and offers to put the site into maintenance mode, but even webmaster administrators is allowed neither. So we copy the important part from UpdateReady::submitForm. Ref DDFHER-183
xendk
force-pushed
the
ddfher-183-webmaster-update-ux
branch
from
693e11d to
2b1471b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-183
Description
The page suggests backing up the site and offers to put the site into maintenance mode, but even webmaster administrators is allowed neither.
So we copy the important part from UpdateReady::submitForm.