Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFBRA-284 - Create basic page for go and add video paragraph #1876

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

Dresse
Copy link
Contributor

@Dresse Dresse commented Dec 18, 2024

Link to issue

I decided to consolidate 2 JIRA tasks in the same PR as they are closely related.

https://reload.atlassian.net/browse/DDFBRA-284
https://reload.atlassian.net/browse/DDFBRA-277

Description

This PR adds a new contenttype called 'GO Page' which we will use for GO specific pages that cannot be categorised into either article or category pages. An example of this could be the frontpage.
The PR adds permissions similar to what the current "Page" contenttype is using.

Furthermore this PR adds a new GO specific paragraph called 'go_video', which is an extended copy of the existing 'video' paragraph (adding a title field). It will likely be extended with more fields in the future.
We will be using this paragraph type specifically for GO content pages (such as the GO Page).

Lastly the PR enables the new 'GO Page' and 'go_video' paragraph in GraphQL Compose.

Screenshot of the result

Example of a GraphQL query that fetches an GO Page and its associated GO video paragraph and its fields:

Screenshot 2024-12-18 at 10 51 41

version of the already existing 'page'. This content type will be used
for creating pages which should be fetched through GraphQL in the GO FE.

For now, we have only added a few fields to the content type. If we need
more fields in the future, we will add those.
already existing permissions used for the 'page' content type.
…age'

node type. I also enabled a few of the paragraph types we need to use on
the 'go_page' contenttype.
version of the already existing 'video' paragraph. The new paragraph type
has an extra field 'go_video_title' and will likely be expanded further in
future.

Also added a new 'Paragraph Category' called 'GO paragraphs'. We will place
the new GO specific paragraphs in this category.

Lastly I also limited which paragraphs the new 'go_page' contenttype can use to be
only the GO specific ones.
Copy link
Contributor

@kasperbirch1 kasperbirch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my knowledge, I think it looks good. 👍 Have you considered whether it would be an advantage to have a "go-paragraphs" page in the default content? like we have "/paragraph-page"?

I'll leave it up to you if you need someone else's opinion on the grapql part.

@kasperbirch1 kasperbirch1 removed their assignment Dec 19, 2024
@Dresse
Copy link
Contributor Author

Dresse commented Dec 19, 2024

From my knowledge, I think it looks good. 👍 Have you considered whether it would be an advantage to have a "go-paragraphs" page in the default content? like we have "/paragraph-page"?

I'll leave it up to you if you need someone else's opinion on the grapql part.

I did not think of that, but it could be a good idea to include this. This would make it easier for the FE team to work with.
Do you know if it is possible to add more paragraphs to the page whenever they become available? Or do you need to create a new default content page each time?

I think I will merge this in for now, and create the go paragraph default content page in another PR. Thanks for the input 👍

@Dresse Dresse merged commit 19862b2 into develop Dec 19, 2024
20 checks passed
@Dresse Dresse deleted the DDFBRA-284-create-basic-page-for-go branch December 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants