Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFBRA-138 - Create task for fetching UUID of the graphql_consumer #1726

Merged

Conversation

Dresse
Copy link
Contributor

@Dresse Dresse commented Nov 5, 2024

Link to issue

https://reload.atlassian.net/browse/DDFBRA-138

Description

Added a new task for fetching the UUID of the graphql_consumer. This UUID is used while calling the GraphQL API.

The task is:

task dev:dpl-go:get-graphql-credentials

It fetches the UUID which should be set in the request headers as X-Consumer-ID

@Dresse Dresse force-pushed the DDFBRA-138-create-task-for-fetching-graphql-credentials branch from 1a49f4f to aa1b405 Compare November 5, 2024 15:23
@spaceo spaceo self-requested a review November 8, 2024 11:44
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make the Drupal part as a drush cmd

logic for fetching consumer UUID from the .module file and into the new
Commands class.

Updated the Taskfile.yml to use the new drush command instead of calling
a function using php-eval.
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I think you should use 15 min in changing: dpl_consumers_get_consumer_uuid () so it throws an error if you cannot resolve the uuid

@spaceo spaceo removed their assignment Nov 20, 2024
to be the correct one.

Also now throws exception whenever we do not get the expected results
returned.
@Dresse Dresse merged commit fb7001a into develop Nov 20, 2024
19 checks passed
@Dresse Dresse deleted the DDFBRA-138-create-task-for-fetching-graphql-credentials branch November 20, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants