Fix missing URLs and titles in the simple_links on the paragraph side (default content).
#1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All links should be able to open in a new tab or window. I enabled DPL Linkit. I also found a bug in the Twig where the path for the target option was incorrect, causing it to always default to self.
kasperbirch1
force-pushed
the
fix-simple-links-in-default-content
branch
from
2efbec0 to
cf71f5a
Compare
kasperbirch1
force-pushed
the
fix-simple-links-in-default-content
branch
from
cf71f5a to
eb7b2ed
Compare
kasperbirch1
force-pushed
the
fix-simple-links-in-default-content
branch
from
eb7b2ed to
5ae660d
Compare
The absence of these nodes was causing issues when editing paragraphs on the paragraph side, so they have now been added. In addition, I have also added a link that opens as a target blank
kasperbirch1
force-pushed
the
fix-simple-links-in-default-content
branch
from
5ae660d to
aa422c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The absence of these elements was causing issues when editing paragraphs on the paragraph side, so they have now been added.