Contextual websearch on tags and categories. DDFFORM-788 #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasben
force-pushed
the
DDFFORM-788_tag-search
branch
from
481ddae to
a20f928
Compare
rasben
force-pushed
the
DDFFORM-788_tag-search
branch
from
a20f928 to
19c1b6f
Compare
rasben
force-pushed
the
DDFFORM-788_tag-search
branch
from
19c1b6f to
8d5fac1
Compare
rasben
force-pushed
the
DDFFORM-788_tag-search
branch
from
8d5fac1 to
341bd86
Compare
|
I know that the config test is failing, but please ignore that - I have no idea why it's happening, but I hope to find a solution for it eventually. |
kasperbirch1
approved these changes
Sep 20, 2024
kasperg
requested changes
Sep 30, 2024
This allows us to create facets and filters, that look both in events and contents.
This is an RSS feed that we do not want.
rasben
force-pushed
the
DDFFORM-788_tag-search
branch
from
341bd86 to
d946b92
Compare
Embedding a contextualized version of the editorial search view directly on 'Categories' and 'Tags' individual term pages. This allows the user to find content that is associated with this term.
rasben
force-pushed
the
DDFFORM-788_tag-search
branch
from
d946b92 to
6ac376f
Compare
For whatever reason these surface when running the following in GitHub Actions: - task dev:reset - task dev:cli -- drush cex They also turn up when running the same from a clean install locally e.g. when running git clean -d -f -x before.
This reverts commit 6ac376f.
The merge request mentioned in the issue (3425506) does not apply. This is a quickfix - once we update search API module, we can remove this patch.
Currently we have newlines set as separators for aggregated fields for tags and categories in the combined content and events index. For whatever reason this adds even more newlines for the separator when configuration is exported again. It turns out the separator is only used for the "concatenation" aggregation type. We use the "union" aggregation type. With this in mind the separator value is actually not used for our use case. To work around the issue we change the separator value to a simple string with a value showing that it is not in used. See https://www.drupal.org/project/search_api/issues/3425506#comment-15490163
…_tag-search-config-issue Fix newline issue as separator for aggregated fields in combined index
kasperg
approved these changes
Oct 1, 2024
It turns out the problem is not addressed with the change in the patch. Consequently we might as well not add it. This way we avoid adding extra work when we need to update the Search API module. This reverts commit a4ca1e3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-788
You can test it by going to an article or event, and click on either a tag or category.
It should lead you to the term page, where related content is shown.
Example:
https://varnish.pr-1524.dpl-cms.dplplat01.dpl.reload.dk/hovedbiblioteket/arrangementer/vi-anbefaler/fars-legestue/2034-01-01
Link tags and categories on full displays, to term pages. DDFFORM-788
Aggregrate event+content tags+categories in search API. DDFFORM-788
This allows us to create facets and filters, that look both in events and contents.
This is an RSS feed that we do not want.
Embedding a contextualized version of the editorial search view directly on 'Categories' and 'Tags' individual term pages.
This allows the user to find content that is associated with this term.