Skip to content

Commit

Permalink
Don't default COMPOSE_PROJECT_NAME in docker-compose.yml
Browse files Browse the repository at this point in the history
If you run a docker compose old enough to not define
COMPOSE_PROJECT_NAME, you're going to run into a whole lot of other
problems anyway.
  • Loading branch information
xendk committed Dec 20, 2024
1 parent bebf0a3 commit 4aa11b4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ services:
NGINX_PROXY_PASS: http://varnish:8080
VIRTUAL_PROTO: https
VIRTUAL_HOST: >-
${COMPOSE_PROJECT_NAME:-dapple-cms}.${DEV_TLD:-docker}
${COMPOSE_PROJECT_NAME}.${DEV_TLD:-docker}
working_dir: /app

varnish: # Caching HTTP reverse proxy that serves (mostly) anonymous requests.
Expand All @@ -66,7 +66,7 @@ services:
- nginx
labels:
lagoon.type: varnish
dev.orbstack.domains: ${COMPOSE_PROJECT_NAME:-dapple-cms}.local
dev.orbstack.domains: ${COMPOSE_PROJECT_NAME}.local
links:
- nginx # links varnish to the nginx in this docker-compose project, or it would try to connect to any nginx running in docker
<< : *default-user # uses the defined user from top
Expand Down

0 comments on commit 4aa11b4

Please sign in to comment.