Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a deprecation log from Floki #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix a deprecation log from Floki #89

wants to merge 1 commit into from

Conversation

msramos
Copy link

@msramos msramos commented Feb 9, 2024

Floki will write info log when if a binary is passed to Floki.text() - which is deprecated. This PR fixes it

@danschultzer
Copy link
Owner

Thanks, can you show me an example that produces this using Premailex.HTMLToPlainText.process/1? The Premailex.HTMLParser specs requires only html_tree types as argument, and I didn't find a way to get it to pass in binary in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msramos @danschultzer