Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails are not sent to the author if no_self_notified #1570

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

uhuntu
Copy link

@uhuntu uhuntu commented Dec 6, 2024

Hi there, I dug long time to know how approval workflow working, I realized that when approved happen, in some cases author would be same as user that mail would send, which means that if user ignore the mail notification which sent by himself, he would not receive the notification that approve initialize by himself. That will be not making sense especially when I change the document and need others review then I would like to receive that others review done case.

Overall, I copy the logic from send documents to bypass the no_self_notified temporally to make it happen. Please kindly review this patch and I am sorry to push it to master as devel branch sadly just support Redmine 6.0.x. I hope this mechanism can be real and I can use it in real. Thank you.

@picman picman changed the base branch from master to devel December 6, 2024 05:58
@picman picman self-requested a review December 6, 2024 05:59
@picman picman added this to the 4.0.0 milestone Dec 6, 2024
Copy link
Collaborator

@picman picman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Rubocop error.

@picman picman merged commit f2c8c4d into danmunn:devel Dec 6, 2024
3 checks passed
@picman
Copy link
Collaborator

picman commented Dec 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants