Emails are not sent to the author if no_self_notified #1570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I dug long time to know how approval workflow working, I realized that when approved happen, in some cases author would be same as user that mail would send, which means that if user ignore the mail notification which sent by himself, he would not receive the notification that approve initialize by himself. That will be not making sense especially when I change the document and need others review then I would like to receive that others review done case.
Overall, I copy the logic from send documents to bypass the no_self_notified temporally to make it happen. Please kindly review this patch and I am sorry to push it to master as devel branch sadly just support Redmine 6.0.x. I hope this mechanism can be real and I can use it in real. Thank you.