Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor bug fixes #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5c43cc
Updates the call to Dreamer to ensure it only trains in training mode
markelsanz14 Jul 10, 2020
4ce18ed
NotImplementedError on ActionDecoder uses a None variable. Replace wi…
markelsanz14 Jul 10, 2020
8436bec
Merge pull request #1 from markelsanz14/patch-2
markelsanz14 Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dreamer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def __call__(self, obs, reset, state=None, training=True):
if state is not None and reset.any():
mask = tf.cast(1 - reset, self._float)[:, None]
state = tf.nest.map_structure(lambda x: x * mask, state)
if self._should_train(step):
if self._should_train(step) and training:
log = self._should_log(step)
n = self._c.pretrain if self._should_pretrain() else self._c.train_steps
print(f'Training for {n} steps.')
Expand Down
2 changes: 1 addition & 1 deletion models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,5 +172,5 @@ def __call__(self, features):
x = self.get(f'hout', tfkl.Dense, self._size)(x)
dist = tools.OneHotDist(x)
else:
raise NotImplementedError(dist)
raise NotImplementedError(self._dist)
return dist