Radiative cooling approximation #610
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke the other cooling methods
…eed profile from the luminosity of the central star. Will need generalizing.
…into ModLomCool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
new physics
Description:
Added the Modified Lombardi cooling approximation as icooling = 9. I have added a new equation of state (ieos=23) which is used by the cooling. There is also an additional setup parameter to use for modelling self-gravitating discs with this method that uses the luminosity of the central star.
Testing:
The code reproduces the expected temperature & density trend for the collapse of a uniform sphere.
Did you run the bots? yes/no
Did you update relevant documentation in the docs directory? yes