Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and cleanup related to star setup #495

Merged
merged 34 commits into from
Feb 1, 2024
Merged

Enhancements and cleanup related to star setup #495

merged 34 commits into from
Feb 1, 2024

Conversation

themikelau
Copy link
Collaborator

@themikelau themikelau commented Jan 30, 2024

Mostly a cleanup of code related to the star setup. Changes include

  • eos: New subroutine calc_rho_from_PT.
    • eos_idealplusrad: New subroutine get_idealplusrad_rhofrompresT.
  • Enhancements to ptmass_calc_enclosed_mass
    • OpenMP parallelisation.
    • Exclude for dead or accreted particles.
    • Non-uniform weights in particle counting.
  • Choice of heating kernels for heating particles around sinks
    • New subroutine heating_kernel allows uniform heating or heating with kernel softening.
  • Increase number of significant figures written out by write_mesa.
  • Core softening enhancements:
    • setfixedentropycore: Improve robustness and error messages for solving a flat-entropy core.
    • set_softened_core: Allow use of finer r-grid in softening region than the arbitrary gridding provided by the input stellar profile.

Changes to fileutils: get_column_labels can now find column headers that are delimited by a varying number of spaces. This fixes a bug where the stellar profile "P12_Phantom_Profile.data" cannot be read.

Wrapping code into functions or subroutines:

  • Query function sink_has_heating to see if any sink particles have heating.
  • Stash solving for u and T in read_star_profile to new subroutine solve_uT_profiles.

danieljprice and others added 30 commits November 19, 2023 19:09
@themikelau themikelau marked this pull request as ready for review January 31, 2024 08:57
@danieljprice danieljprice merged commit b299d2f into master Feb 1, 2024
177 checks passed
@danieljprice danieljprice deleted the star branch February 1, 2024 00:46
@danieljprice
Copy link
Owner

thanks Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants