-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements and cleanup related to star setup #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in equilibrium with heating
…l when iopacity_type=1
… instead of ieos=2 when using radiation
…to separate subroutine
…for softened profile
…sing ieos from eos module
…function according to heating kernel
… fruitless endeavour
… number of spaces
danieljprice
approved these changes
Feb 1, 2024
thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a cleanup of code related to the
star
setup. Changes includeeos
: New subroutinecalc_rho_from_PT
.eos_idealplusrad
: New subroutineget_idealplusrad_rhofrompresT
.ptmass_calc_enclosed_mass
heating_kernel
allows uniform heating or heating with kernel softening.write_mesa
.setfixedentropycore
: Improve robustness and error messages for solving a flat-entropy core.set_softened_core
: Allow use of finer r-grid in softening region than the arbitrary gridding provided by the input stellar profile.Changes to
fileutils
:get_column_labels
can now find column headers that are delimited by a varying number of spaces. This fixes a bug where the stellar profile "P12_Phantom_Profile.data" cannot be read.Wrapping code into functions or subroutines:
sink_has_heating
to see if any sink particles have heating.read_star_profile
to new subroutinesolve_uT_profiles
.