-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rangeslider doesn't work with newer versions of minified videojs #8
Comments
It could be great if you fix it. Please let me know if you need anything |
Hi, first thanks for the plug in. Do you got any update for those compatibility issues with the minified versions of videojs? |
Not yet, but you could open an issue in videojs if you like |
I just tried with newest minified version of videojs (4.9.1) and so far I have seen that these things are not comptaible any more:
|
I tried for two hours debugging and changing code of rangeslider to make it compatible with minified and obfuscation version of video.js. Unfortunately at some point I gave up, as I lacked understanding behind parts of code. I think @danielcebrian should have look at this modified code whenever he has got some time and see whats missing https://github.com/papoola/rangeslider-videojs/compare/obfuscated-videojs-compatible @nobe4 best thing you can do at the moment (which I did as well) is to go to http://refresh-sf.com/yui/ and copy/paste unminified version of video.js and check option |
Has anyone made in progress on this? @wilsonwc, were you able to patch this? If not, I'm going to spend some time looking at this issue. |
Hello Guys, Is the issue resolved? I am still not able to use range slider plugin with video.js |
@harishsalian05 if you follow my instructions you can get it to work with a customized minified version of video.js |
Thank you @papoola for the answer and sorry guys but I am still stuck in solving this. The solution could be to modify the videojs compilator |
Is there any progress on this issue? |
I am on different project and I am so sorry but I could no mantain this project for now. If you want to try, I am happy to help you. |
It looks like newer minified versions of videojs are not compatible with rangeslider. This seems to be because of the plugin referencing internal variables like .options_. I will try to get a patch together in the next few days to fix the issue.
The text was updated successfully, but these errors were encountered: