Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rangeslider doesn't work with newer versions of minified videojs #8

Open
wilsonwc opened this issue Jun 1, 2014 · 11 comments
Open

Comments

@wilsonwc
Copy link

wilsonwc commented Jun 1, 2014

It looks like newer minified versions of videojs are not compatible with rangeslider. This seems to be because of the plugin referencing internal variables like .options_. I will try to get a patch together in the next few days to fix the issue.

@danielcebrian
Copy link
Owner

It could be great if you fix it. Please let me know if you need anything

@tebanhdez
Copy link

Hi, first thanks for the plug in. Do you got any update for those compatibility issues with the minified versions of videojs?

@danielcebrian
Copy link
Owner

Not yet, but you could open an issue in videojs if you like

@papoola
Copy link

papoola commented Oct 24, 2014

I just tried with newest minified version of videojs (4.9.1) and so far I have seen that these things are not comptaible any more:

videojs.SeekBar.prototype.options_ - has been renamed to videojs.ControlBar.prototype.l in minified version
videojs.ControlBar.prototype.options_ - has been renamed to videojs.ControlBar.prototype.l in minified version
videojs.blockTextSelection() - doesnt exist any more
videojs.formatTime() - doesnt exist any more
videojs.removeClass() - doesnt exist any more

@papoola
Copy link

papoola commented Nov 17, 2014

I tried for two hours debugging and changing code of rangeslider to make it compatible with minified and obfuscation version of video.js. Unfortunately at some point I gave up, as I lacked understanding behind parts of code. I think @danielcebrian should have look at this modified code whenever he has got some time and see whats missing https://github.com/papoola/rangeslider-videojs/compare/obfuscated-videojs-compatible

@nobe4 best thing you can do at the moment (which I did as well) is to go to http://refresh-sf.com/yui/ and copy/paste unminified version of video.js and check option Minify only, no symbol obfuscation. and this way create your own minified version of video.js which does work with rangeslider.

@rsadwick
Copy link

Has anyone made in progress on this? @wilsonwc, were you able to patch this? If not, I'm going to spend some time looking at this issue.

@harishsalian05
Copy link

Hello Guys, Is the issue resolved? I am still not able to use range slider plugin with video.js
@danielcebrian Can you please help us in it?

@papoola
Copy link

papoola commented Mar 30, 2015

@harishsalian05 if you follow my instructions you can get it to work with a customized minified version of video.js

@danielcebrian
Copy link
Owner

Thank you @papoola for the answer and sorry guys but I am still stuck in solving this. The solution could be to modify the videojs compilator

@tessact
Copy link

tessact commented Jan 24, 2017

Is there any progress on this issue?

@danielcebrian
Copy link
Owner

I am on different project and I am so sorry but I could no mantain this project for now. If you want to try, I am happy to help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants