Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin development #2016

Closed
stacy-andrews opened this issue Apr 7, 2015 · 1 comment
Closed

Plugin development #2016

stacy-andrews opened this issue Apr 7, 2015 · 1 comment

Comments

@stacy-andrews
Copy link

Hi

I am trying to fix the following outstanding issue with the Range Slider plugin... danielcebrian/rangeslider-videojs#8

The plugin relies on the Component model which has the options_ field and the createEl field, both of which are uglified as part of the video.js build process. Is there some way to create components that does not use these uglified functions and fields? A pointer in the right direction would be greatly appreciated.

Stacy Andrews

@mmcc
Copy link
Member

mmcc commented Apr 7, 2015

We've switched to Uglify in master (so for 5.0), so this shouldn't be an issue moving forward. In the meantime, there's really not a great answer short of using the dev (not minified) version of Video.js or forking / adding things to the exports for closure compiler.

I know those aren't great solutions, but this will be better soon. I'd tell you to go ahead and use master, but there are still a few pending PRs that need to get merged in before folks should think about using it.

@mmcc mmcc closed this as completed Apr 7, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants