Do not depend on warp default features #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive dependency buf_redux which will not compile in future Rust versions
|
Hi @beltram , sorry for the delay on this. I Actually got no notification (or probably got flooded by some others). I'll take a look, but if it is not needed it would actually make sense. Thanks for all. |
|
hi! :) any chance we could get a new release with this change included? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, just got a warning in my project starting Rust 1.68 that in future Rust version it won't compile because of
buf_reduxcrate which is a transitive dependency of this crate throughmultipartcrate which is also a default feature of warp.Since this is not required by this crate, I propose you to stop relying upon warp default features.
More details about the compilation issue here. It looks like it won't be resolved anytime soon