Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bootstrap form layout support ... #47

Closed
wants to merge 1 commit into from

Conversation

maxfelker
Copy link

We are using this project as a part of our production level Angular app. Love the setup but it does have two things we didn't like about it:

By wrapping elements the divs and corresponding bootstrap classes, I was able to successfully get this to work. What do you think?

@danhunsaker
Copy link
Owner

This is a Bootstrap-specific change. I'd prefer something more flexible, allowing HTML micro-templates to be provided for each control type, instead of hard-coding a single layout. It'll need a hard-coded fallback, but otherwise... Then we just include some micro-template collections for each of the major UIs (including Bootstrap) and let the user include the appropriate ones as needed.

@TroyWolf
Copy link

TroyWolf commented Dec 1, 2015

maxatbrs, I found this thread looking for how I might be able to wrap my form elements in a DIV that includes Bootstrap class(es). While I understand danhunsaker's desire for a generic solution, I am very interested in your changes now. How do I take advantage of the work you've done?

danhunsaker, in the interim, would it be possible to take the work maxatbrs has done to "Boostrapize" your project and make it a config thing? So you get your solution without the Bootstrap wrapping or flip a switch and get things Bootstrapped. Possible?

@TroyWolf
Copy link

TroyWolf commented Dec 1, 2015

The Angular-Formly project seems to do everything I wanted angular-dynforms for and a WHOLE lot more including templates (Bootstrap and others), custom templates, loading templates via HTTP, etc.
http://angular-formly.com/

@danhunsaker
Copy link
Owner

I listed a whole bunch of alternatives at the bottom of the README. I'll try to remember to add this one at some point.

@maxfelker maxfelker closed this Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants