Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16 support #627

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Xcode 16 support #627

merged 11 commits into from
Oct 14, 2024

Conversation

f-meloni
Copy link
Member

Removing older Xcode version to add Xcode 16 and not increase CI time too much

Copy link

github-actions bot commented Oct 14, 2024

Warnings
⚠️

Any changes to library code should be reflected in the Changelog.

Please consider adding a note there and adhere to the Changelog Guidelines.

⚠️

Sources/Danger/Danger.swift#L76 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/DangerDSL.swift#L61 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/Danger/DangerUtils.swift#L58 - where clauses are preferred over a single if inside a for (for_where)

⚠️

Sources/Danger/GitDiff.swift#L122 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/Danger/GitDiff.swift#L171 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L52 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L75 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L186 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L202 - The disabled 'function_parameter_count' rule should be re-enabled before the end of the file (blanket_disable_command)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L211 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L243 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L256 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Plugins/SwiftLint/SwiftLint.swift#L285 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Danger/Report.swift#L120 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/DangerDependenciesResolver/InlineDependenciesFinder.swift#L10 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/InlineDependenciesFinder.swift#L17 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/InlineDependenciesFinder.swift#L52 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/Package.swift#L93 - Variable name 'v1' should be between 3 and 40 characters long (identifier_name)

⚠️

Sources/DangerDependenciesResolver/PackageDataProvider.swift#L20 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/PackageDataProvider.swift#L73 - Enum element name 'v1' should be between 3 and 40 characters long (identifier_name)

⚠️

Sources/DangerDependenciesResolver/PackageDataProvider.swift#L75 - Enum element name 'v2' should be between 3 and 40 characters long (identifier_name)

⚠️

Sources/DangerDependenciesResolver/PackageGenerator.swift#L10 - Declaration masterPackageName contains the term "master" which is not considered inclusive (inclusive_language)

⚠️

Sources/DangerDependenciesResolver/PackageGenerator.swift#L16 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/PackageGenerator.swift#L27 - Declaration generateMasterPackageDescription contains the term "master" which is not considered inclusive (inclusive_language)

⚠️

Sources/DangerDependenciesResolver/PackageGenerator.swift#L29 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/PackageManager.swift#L21 - Declaration masterPackageName contains the term "master" which is not considered inclusive (inclusive_language)

⚠️

Sources/DangerDependenciesResolver/PackageManager.swift#L28 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/PackageManager.swift#L41 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/PackageManager.swift#L71 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/DangerDependenciesResolver/PackageManager.swift#L128 - Declaration masterDescription contains the term "master" which is not considered inclusive (inclusive_language)

⚠️

Sources/DangerDependenciesResolver/Script.swift#L15 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/Script.swift#L43 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerDependenciesResolver/Script.swift#L235 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerFixtures/DangerFixtures.swift#L43 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L25 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L33 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L40 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L48 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L60 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L83 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L122 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/DangerShellExecutor/ShellExecutor.swift#L124 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/Runner/Commands/Edit.swift#L9 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/Runner/Commands/Edit.swift#L19 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/Runner/Commands/RunDangerJS.swift#L5 - Function body should span 50 lines or less excluding comments and whitespace: currently spans 51 lines (function_body_length)

⚠️

Sources/Runner/Commands/RunDangerJS.swift#L55 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Runner/Commands/Runner.swift#L135 - The enabled 'line_length' rule was not disabled (blanket_disable_command)

⚠️

Sources/Runner/Commands/Runner.swift#L161 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Runner/MarathonScriptManager.swift#L7 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/Runner/MarathonScriptManager.swift#L9 - Lines should not have trailing whitespace (trailing_whitespace)

⚠️

Sources/RunnerLib/CliArgs/CliArgsParser.swift#L11 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/RunnerLib/Files Import/ImportsFinder.swift#L16 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/RunnerLib/GetDangerJSPath.swift#L8 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/RunnerLib/GetDangerJSPath.swift#L11 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/RunnerLib/GetDangerJSPath.swift#L19 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/RunnerLib/SPMDanger.swift#L38 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Sources/RunnerLib/SPMDanger.swift#L60 - Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)

⚠️

Tests/DangerDependenciesResolverTests/InlineDependenciesFinderTests.swift#L24 - TODOs should be resolved (Fix on Linux with Swift 6.0) (todo)

⚠️

Tests/DangerTests/SwiftLint/DangerSwiftLintTests.swift#L5 - The disabled 'type_body_length' rule should be re-enabled before the end of the file (blanket_disable_command)

⚠️

Tests/DangerTests/SwiftLint/DangerSwiftLintTests.swift#L414 - Line should be 140 characters or less; currently it has 142 characters (line_length)

Generated by 🚫 Danger Swift against fcb3bd5

@f-meloni f-meloni changed the title Run CI also on Xcode 16 Xcode 16 support Oct 14, 2024
@f-meloni f-meloni merged commit 361a83f into master Oct 14, 2024
16 checks passed
@f-meloni f-meloni deleted the xcode_16_ci branch October 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant