Skip to content

Commit

Permalink
Merge branch 'master' into review-before-submmitted
Browse files Browse the repository at this point in the history
  • Loading branch information
f-meloni authored Oct 14, 2024
2 parents 6c83da5 + 407e5b0 commit b8721e6
Show file tree
Hide file tree
Showing 5 changed files with 150 additions and 3 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,13 @@
-->

## Master
- Remove deprecated `lint` function with `lintAllFiles` flag [@417-72KI][] - [#622](https://github.com/danger/swift/pull/622)

- Fix: `GitHub.Review.submittedAt` may be `nil` [@417-72KI][] - [#624](https://github.com/danger/swift/pull/624)

## 3.20.0
- Remove deprecated `lint` function with `lintAllFiles` flag [@417-72KI][] - [#622](https://github.com/danger/swift/pull/622)
- Updated Swift 6 build process: Danger files moved to .build/debug/Modules, and SwiftFormat module map conflict resolved by adjusting the Swift import search path. [@abhi-m-simformsolutons][] -[#626](https://github.com/danger/swift/pull/626)

## 3.19.1

- Expose markdownKit on Swiftlint.lint() for customizing the output [@nikoloutsos][] - [#610](https://github.com/danger/swift/pull/610)
Expand Down
135 changes: 135 additions & 0 deletions Package.resolved
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
{
"pins" : [
{
"identity" : "collectionconcurrencykit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/JohnSundell/CollectionConcurrencyKit.git",
"state" : {
"revision" : "b4f23e24b5a1bff301efc5e70871083ca029ff95",
"version" : "0.2.0"
}
},
{
"identity" : "cryptoswift",
"kind" : "remoteSourceControl",
"location" : "https://github.com/krzyzanowskim/CryptoSwift.git",
"state" : {
"revision" : "678d442c6f7828def400a70ae15968aef67ef52d",
"version" : "1.8.3"
}
},
{
"identity" : "komondor",
"kind" : "remoteSourceControl",
"location" : "https://github.com/shibapm/Komondor",
"state" : {
"revision" : "dedffeaf42a1b52bf072a9dc47afb35000a8b265",
"version" : "1.1.4"
}
},
{
"identity" : "logger",
"kind" : "remoteSourceControl",
Expand All @@ -18,6 +45,15 @@
"version" : "0.13.0"
}
},
{
"identity" : "packageconfig",
"kind" : "remoteSourceControl",
"location" : "https://github.com/shibapm/PackageConfig.git",
"state" : {
"revision" : "58523193c26fb821ed1720dcd8a21009055c7cdb",
"version" : "1.1.3"
}
},
{
"identity" : "requestkit",
"kind" : "remoteSourceControl",
Expand All @@ -27,6 +63,60 @@
"version" : "3.3.0"
}
},
{
"identity" : "rocket",
"kind" : "remoteSourceControl",
"location" : "https://github.com/shibapm/Rocket",
"state" : {
"revision" : "32af356776108ee7289884874a0eb63ceacb9e5d",
"version" : "1.3.0"
}
},
{
"identity" : "shellout",
"kind" : "remoteSourceControl",
"location" : "https://github.com/JohnSundell/ShellOut.git",
"state" : {
"revision" : "e1577acf2b6e90086d01a6d5e2b8efdaae033568",
"version" : "2.3.0"
}
},
{
"identity" : "sourcekitten",
"kind" : "remoteSourceControl",
"location" : "https://github.com/jpsim/SourceKitten.git",
"state" : {
"revision" : "fd4df99170f5e9d7cf9aa8312aa8506e0e7a44e7",
"version" : "0.35.0"
}
},
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-argument-parser.git",
"state" : {
"revision" : "41982a3656a71c768319979febd796c6fd111d5c",
"version" : "1.5.0"
}
},
{
"identity" : "swift-snapshot-testing",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-snapshot-testing.git",
"state" : {
"revision" : "7b0bbbae90c41f848f90ac7b4df6c4f50068256d",
"version" : "1.17.5"
}
},
{
"identity" : "swift-syntax",
"kind" : "remoteSourceControl",
"location" : "https://github.com/swiftlang/swift-syntax",
"state" : {
"revision" : "515f79b522918f83483068d99c68daeb5116342d",
"version" : "600.0.0-prerelease-2024-08-14"
}
},
{
"identity" : "swiftformat",
"kind" : "remoteSourceControl",
Expand All @@ -36,6 +126,42 @@
"version" : "0.54.3"
}
},
{
"identity" : "swiftlint",
"kind" : "remoteSourceControl",
"location" : "https://github.com/Realm/SwiftLint",
"state" : {
"revision" : "168fb98ed1f3e343d703ecceaf518b6cf565207b",
"version" : "0.57.0"
}
},
{
"identity" : "swiftshell",
"kind" : "remoteSourceControl",
"location" : "https://github.com/kareman/SwiftShell",
"state" : {
"revision" : "99680b2efc7c7dbcace1da0b3979d266f02e213c",
"version" : "5.1.0"
}
},
{
"identity" : "swiftytexttable",
"kind" : "remoteSourceControl",
"location" : "https://github.com/scottrhoyt/SwiftyTextTable.git",
"state" : {
"revision" : "c6df6cf533d120716bff38f8ff9885e1ce2a4ac3",
"version" : "0.9.0"
}
},
{
"identity" : "swxmlhash",
"kind" : "remoteSourceControl",
"location" : "https://github.com/drmohundro/SWXMLHash.git",
"state" : {
"revision" : "a853604c9e9a83ad9954c7e3d2a565273982471f",
"version" : "7.0.2"
}
},
{
"identity" : "version",
"kind" : "remoteSourceControl",
Expand All @@ -44,6 +170,15 @@
"revision" : "1fe824b80d89201652e7eca7c9252269a1d85e25",
"version" : "2.0.1"
}
},
{
"identity" : "yams",
"kind" : "remoteSourceControl",
"location" : "https://github.com/jpsim/Yams",
"state" : {
"revision" : "3036ba9d69cf1fd04d433527bc339dc0dc75433d",
"version" : "5.1.3"
}
}
],
"version" : 2
Expand Down
2 changes: 1 addition & 1 deletion Sources/Runner/Commands/Runner.swift
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func runDanger(version dangerSwiftVersion: String, logger: Logger) throws {
if let spmDanger = SPMDanger() {
spmDanger.buildDependencies(executor: executor)
libArgs += ["-L", spmDanger.buildFolder]
libArgs += ["-I", spmDanger.buildFolder]
libArgs += ["-I", spmDanger.moduleFolder]
libArgs += [spmDanger.swiftcLibImport]
} else {
guard let libDangerPath = Runtime.getLibDangerPath() else {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Runner/main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Logger
import RunnerLib

/// Version for showing in verbose mode
let DangerVersion = "3.19.1" // swiftlint:disable:this identifier_name
let DangerVersion = "3.20.0" // swiftlint:disable:this identifier_name
let MinimumDangerJSVersion = "6.1.6" // swiftlint:disable:this identifier_name

private func runCommand(_ command: DangerCommand, logger: Logger) throws {
Expand Down
8 changes: 8 additions & 0 deletions Sources/RunnerLib/SPMDanger.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ public struct SPMDanger {
fileManager.currentDirectoryPath + "/.build/debug"
}

public var moduleFolder: String {
#if compiler(<6.0)
buildFolder
#else
buildFolder + "/Modules"
#endif
}

public init?(
packagePath: String = "Package.swift",
readFile: (String) -> String? = { try? String(contentsOfFile: $0) },
Expand Down

0 comments on commit b8721e6

Please sign in to comment.