Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using head_pipeline instead of pipeline in GitLab #289

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

grine4ka
Copy link

Due to GitLab docs we should prefer using head_pipeline instead of pipeline as it contains more information.

Additional to that, sometimes I caught crashes on danger-kotlin when pipeline status was incorrect in that field or even when pipeline field was null.
But I can't just mark pipeline field as nullable, cause it will cause backward incompatibility.

- Due to [GitLab docs](https://docs.gitlab.com/ee/api/merge_requests.html) we should prefer using head_pipeline instead of pipeline as it contains more information
- Fix Gitlab pipeline status test
@Vacxe Vacxe merged commit 1d57d8b into danger:master Oct 23, 2024
3 checks passed
@grine4ka grine4ka deleted the change-using-gitlab-head-pipeline branch October 25, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants