Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in GitLab Pipeline status name #287

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

grine4ka
Copy link

Due to GitLab Pipelines API documentation name for the cancelled pipeline status is canceled instead of cancelled. This PR fixes that issue.

Also, added tests for this gitlab pipeline status name.

Grigoriy Bykov added 2 commits October 17, 2024 11:33
- Due to [GitLab Pipelines API documentation](https://docs.gitlab.com/ee/api/pipelines.html) name for the cancelled pipeline status is `canceled` instead of `cancelled`. This PR fixes that issue.
- Add tests for GitLab Pipeline cancelled status
Copy link
Member

@Vacxe Vacxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I'll try to prepare a minor release asap

@Vacxe
Copy link
Member

Vacxe commented Oct 17, 2024

@grine4ka I'll take a look why CI pipelines was broken and will rebase your PR, no worries

@grine4ka
Copy link
Author

@grine4ka I'll take a look why CI pipelines was broken and will rebase your PR, no worries

Thanks a lot. ❤️

@Vacxe Vacxe merged commit 9381885 into danger:master Oct 18, 2024
3 checks passed
@grine4ka grine4ka deleted the bugfix/typo-in-gitlab-pipeline-status branch October 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants