Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions, add local replace directive #2

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Update versions, add local replace directive #2

merged 2 commits into from
Aug 23, 2023

Conversation

echarrod
Copy link
Collaborator

Added

  • Local replace directive, so we won't have to continue updating the version referenced in the build/ci sub-module

Changed

  • Updated github.com/stretchr/testify => v1.8.4

@echarrod
Copy link
Collaborator Author

CI will pass once the change to remove the replace directive is merged:

replace github.com/luno/danger-go v0.0.0-20230121134440-81ada33efa08 => github.com/moolmanruan/danger-go v0.1.0

I tested the failed command with this command, which points to the latest commit on this branch:

 go install github.com/luno/danger-go/cmd/danger-go@479b52ab29febb0869fe701aa2f7bf28b9e0f42b

@echarrod echarrod merged commit 430f038 into main Aug 23, 2023
1 of 2 checks passed
@echarrod echarrod deleted the Update-versions branch August 23, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhicks adamhicks adamhicks approved these changes

@neilgarb neilgarb Awaiting requested review from neilgarb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarrod @adamhicks