Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renovate: Use base config #15

Merged
merged 3 commits into from
Jul 22, 2024
Merged

renovate: Use base config #15

merged 3 commits into from
Jul 22, 2024

Conversation

echarrod
Copy link
Collaborator

Changed

  • Renovate config to use base config

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Messages
📖 0 new files added!
📖 1 files modified!

Generated by 🚫 dangerJS against c8ca1ce

wenkanglu
wenkanglu suggested changes Jul 22, 2024
View reviewed changes
Copy link

@wenkanglu wenkanglu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that the name doesn't match what was linked (default-renovate-config.json5 vs renovate-default-config.json5). Same for the other PRs.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@echarrod
Copy link
Collaborator Author

Just saw that the name doesn't match what was linked (default-renovate-config.json5 vs renovate-default-config.json5). Same for the other PRs.

Ah thanks Gary, good spot! Updated. It should match the name of the file declared at https://github.com/luno/.github/blob/main/renovate-default-config.json5

@echarrod echarrod merged commit a33ad59 into main Jul 22, 2024
3 checks passed
@echarrod echarrod deleted the ed-renovate-use-base-config branch July 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenkanglu wenkanglu wenkanglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarrod @wenkanglu