Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reject with real errors for GitLab API calls for better debugging #1465

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: reject with real errors for GitLab API calls for better debugging #1465

merged 1 commit into from
Sep 24, 2024
+3 −6

Commits on Sep 24, 2024

  1. fix: reject with real errors for GitLab API calls for better debugging 

    In previous implementation, some GitLab API calls would make a Promise rejection with `undefined` as the reason.
And in the [global `unhandledRejection` handler](https://github.com/frantic1048/danger-js/blob/b67d710af4d177d57e7091a742da54a2e9fa37fc/source/commands/utils/sharedDangerfileArgs.ts#L5), it will print a generic "Error: undefined" message.
This makes debugging very hard.

This commit fixes the issue by filling in the rejection reason with the actual error.
    @frantic1048
    frantic1048 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b62df49 View commit details
    Browse the repository at this point in the history