Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove GITHUB_URL environment variable as a fallback for the GitHub API URL #1458

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: remove GITHUB_URL environment variable as a fallback for the GitHub API URL #1458

merged 1 commit into from
Aug 6, 2024

Conversation

3w36zj6
Copy link
Contributor

@3w36zj6 3w36zj6 commented Jul 23, 2024

close #1374

@orta
Copy link
Member

orta commented Jul 26, 2024

Seems reasonable to me, as @fbartho made the issue I'll let him double check but otherwise I'm happy

fbartho
fbartho approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@orta orta merged commit b67d710 into danger:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbartho fbartho fbartho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] GITHUB_URL is magic in Github-hosted-runners, but shouldn't be used for API Calls
3 participants
@3w36zj6 @orta @fbartho