Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Suggestions for #991 #1192

Merged
merged 341 commits into from
Jan 8, 2022
Merged

PR Suggestions for #991 #1192

merged 341 commits into from
Jan 8, 2022

Conversation

fbartho
Copy link
Member

@fbartho fbartho commented Jan 7, 2022

Didn't want to step on your branch too much @orta, so I made a separate PR

This PR Merges main as well as applying typo-fixes as I suggested in #991

orta and others added 30 commits April 16, 2020 08:08
Having files under folders with white space will fail get content of file as it end in node-fetch error
TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters
Fix: BitBucketServer does not encode filepath
I didn't realize my `origin` wasn't on my fork, and I ended up pushing
some debug code directly! 😳

_I was tempted to force push, but I already made enough damage for one
night_ 😞

In order to prevent me from doing something this silly again, what do
you think of adding a branch protection rule to prevent direct pushes to
`master`?
…stake

Remove extra logging that made it to master accidentally
Wait for close event on spawned process in local git
Document how to disable transpilation
Get blob url for pr commit.
orta and others added 25 commits November 19, 2021 12:08
Add ability to ouput results as JSON
[Maintenance] Switch to node-14 as the oldest tested environment
Ensures the PR always has a body
Fix: [Github] Multiple Inline Comments on the same file/line should all be posted
@fbartho fbartho requested a review from orta January 7, 2022 21:25
@orta
Copy link
Member

orta commented Jan 8, 2022

Bit too big of a PR to review, will take a look in the merged brach 👍🏻

@orta orta merged commit f58b6a1 into fs_lookup Jan 8, 2022
@fbartho fbartho deleted the fb/fs_lookup branch January 10, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.