Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize show instances #655

Closed
wants to merge 30 commits into from
Closed

Visualize show instances #655

wants to merge 30 commits into from

Conversation

DannieSheng
Copy link
Contributor

@DannieSheng DannieSheng commented Dec 1, 2020 •
edited
Loading

Describe your changes
Directly related to issue #652

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues
#587

Additional context
This pull request need to be merged before merging #587

@DannieSheng DannieSheng added the new feature New feature ideas and solutions label Dec 1, 2020
@DannieSheng DannieSheng added this to the PlantCV v4.x milestone Dec 1, 2020
@DannieSheng DannieSheng self-assigned this Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #655 (7979d0e) into 4.x (e5b78d7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               4.x      #655   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          145       146    +1     
  Lines         6662      6737   +75     
=========================================
+ Hits          6662      6737   +75
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/hyperspectral/read_data.py 100.00% <100.00%> (ø)
plantcv/plantcv/visualize/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/visualize/display_instances.py 100.00% <100.00%> (ø)

@HaleySchuhl HaleySchuhl requested review from HaleySchuhl and removed request for HaleySchuhl December 18, 2020 20:12
@DannieSheng DannieSheng changed the base branch from master to 4.x March 18, 2021 20:49
HaleySchuhl
HaleySchuhl approved these changes Mar 18, 2021
View reviewed changes
plantcv/plantcv/visualize/display_instances.py Outdated Show resolved Hide resolved
plantcv/plantcv/visualize/display_instances.py Outdated Show resolved Hide resolved
@DannieSheng DannieSheng added the work in progress Mark work in progress label Apr 27, 2021
@DannieSheng DannieSheng added ready to review and removed work in progress Mark work in progress labels Apr 28, 2021
@DannieSheng DannieSheng added work in progress Mark work in progress ready to review and removed ready to review work in progress Mark work in progress labels Aug 17, 2021
@JorgeGtz JorgeGtz added work in progress Mark work in progress and removed ready to review labels Jan 27, 2022
@HaleySchuhl
Copy link
Contributor

Archiving for now, plan to revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl requested changes

@nfahlgren nfahlgren Awaiting requested review from nfahlgren

Assignees

@DannieSheng DannieSheng

Labels
new feature New feature ideas and solutions work in progress Mark work in progress
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@DannieSheng @HaleySchuhl @JorgeGtz