Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata attribute to spectral_data class #1595

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented Sep 9, 2024

Describe your changes
Previously, we had added some additional attributes to the spectral_data class to accommodate some of the metadata associated with geospatial data. This PR now replaces those individual metadata terms with an attribute called "metadata". The default is an empty dictionary, but it can be populated with any number of keys specific to various data types, like hyperspectral and geospatial.

Type of update
Is this a:

  • New feature or feature enhancement

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added this to the PlantCV v4.x milestone Sep 9, 2024
Copy link

deepsource-io bot commented Sep 9, 2024

Here's the code health analysis summary for commits 26bfd9a..a3ad6c3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl self-requested a review September 9, 2024 20:25
@k034b363 k034b363 changed the title Add geo_res attribute to spectral data class Add metadata attribute to spectral_data class Sep 13, 2024
@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels Sep 13, 2024
@nfahlgren nfahlgren merged commit 1242505 into main Sep 13, 2024
5 checks passed
@nfahlgren nfahlgren deleted the add_geores_to_spectral branch September 13, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants