Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geospatial attributes to spectral_data class #1580

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented Aug 13, 2024

Describe your changes
Some functions in the add-on packaged plantcv-geospatial benefit from having additional metadata stored as attributes of spectral_data objects. This PR adds geo_transform and geo_crs, the affine transformation matrix to convert from geo referenced coordinates to raster coordinates and the coordinate system respectively. Because they are both added with appropriate defaults (the identity matrix and "None"), this change should not affect any core plantcv functions.

Type of update

  • New feature or feature enhancement (kind of)

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added work in progress Mark work in progress update Updates an existing feature/method labels Aug 13, 2024
@k034b363 k034b363 added this to the PlantCV v4.x milestone Aug 13, 2024
@k034b363 k034b363 self-assigned this Aug 13, 2024
Copy link

deepsource-io bot commented Aug 13, 2024

Here's the code health analysis summary for commits 4b7c85d..7cce552. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added ready to review work in progress Mark work in progress and removed work in progress Mark work in progress ready to review labels Aug 13, 2024
@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels Aug 13, 2024
@nfahlgren nfahlgren modified the milestones: PlantCV v4.x, PlantCV v4.4 Aug 14, 2024
@nfahlgren nfahlgren merged commit 0f51190 into main Aug 14, 2024
5 checks passed
@nfahlgren nfahlgren deleted the add-transform-attribute branch August 14, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants