Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1575 image tiling #1578

Merged
merged 37 commits into from
Aug 16, 2024
Merged

1575 image tiling #1578

merged 37 commits into from
Aug 16, 2024

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented Aug 12, 2024

Describe your changes
This function takes as input a list of images and a desired number of rows and columns and outputs a composite image. Tiling is expected to be useful for visualizing the results of several kmeans model fits with changing parameters.

Type of update

  • New feature or feature enhancement

Associated issues
This PR closes issue #1575

Additional context

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Aug 12, 2024

Here's the code health analysis summary for commits 248f983..cf74ff1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added this to the PlantCV v4.x milestone Aug 12, 2024
@k034b363 k034b363 added new feature New feature ideas and solutions work in progress Mark work in progress labels Aug 12, 2024
@k034b363 k034b363 self-assigned this Aug 12, 2024
@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels Aug 14, 2024
@HaleySchuhl HaleySchuhl self-requested a review August 16, 2024 18:53
Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The orientation of the seeds pointing at each other in the tile output in the doc image is so satisfying haha. I just tweaked the unit test a little to use preexisting test data.

@nfahlgren nfahlgren merged commit b1a14e9 into main Aug 16, 2024
5 checks passed
@nfahlgren nfahlgren deleted the 1575-image-tiling branch August 16, 2024 22:52
@nfahlgren nfahlgren modified the milestones: PlantCV v4.x, PlantCV v4.4 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions ready to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Image tiling
3 participants