Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kmeans grayscale #1570

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Kmeans grayscale #1570

wants to merge 5 commits into from

Conversation

leafism9
Copy link
Collaborator

Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.

For any previously RGB specific lines in patch_extract() or predict_kmeans(), the added code checks the number of dimensions and number of channels in the image and chooses the RGB or grayscale vesion of the line accordingly. This is a non-breaking feature enhancement that allows grayscale functionality to the preexisting kmeans functions.

Type of update
Is this a: New feature or feature enhancement

Associated issues
Reference associated issue numbers. Does this pull request close any issues?
N/A

Additional context
Add any other context about the problem here.
N/A

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Jul 23, 2024

Here's the code health analysis summary for commits 4b7c85d..57d2cb1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added enhancement Enhancements to existing features ready to review labels Jul 23, 2024
@k034b363 k034b363 added this to the PlantCV v4.x milestone Jul 23, 2024
@k034b363 k034b363 requested a review from annacasto July 23, 2024 18:05
@k034b363 k034b363 added work in progress Mark work in progress and removed ready to review labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features work in progress Mark work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants