Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepsource fixes for hyper_histogram #1500

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

natejly
Copy link
Collaborator

@natejly natejly commented Apr 20, 2024

Removed default mutable args and reduced complexity of update_color_dict

Includes fixes for
-Unnecessary comprehension (PTC-W0016)
-Dangerous default argument (PYL-W0102)

Copy link

deepsource-io bot commented Apr 20, 2024

Here's the code health analysis summary for commits 4b7c85d..17fc4ad. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 4 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@natejly natejly closed this May 17, 2024
@natejly natejly reopened this May 17, 2024
@natejly natejly added the work in progress Mark work in progress label May 17, 2024
@natejly natejly changed the title small deepsource fixes for hyper_histogram Deepsource fixes for hyper_histogram May 17, 2024
@natejly natejly added ready to review cleanup Code quality updates and removed work in progress Mark work in progress labels May 17, 2024
@natejly natejly self-assigned this May 17, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.4 milestone Jul 9, 2024
@HaleySchuhl HaleySchuhl removed this from the PlantCV v4.4 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

3 participants