Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove max_val param from threshold._call_threshold() #1220

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

afinit
Copy link
Collaborator

@afinit afinit commented Jul 6, 2023

This PR Builds on:

Describe your changes

  • Removes max_val param from the threshold._call_threshold internal method

Type of update
feature enhancement

Associated issues
completes one task from this ticket: #1194

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@afinit afinit added this to the PlantCV v4.0 milestone Jul 6, 2023
Base automatically changed from release-4.0-texture-max-val to release-4.0 July 6, 2023 18:24
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1220 (fe1c4bb) into release-4.0 (36ab769) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0     #1220   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              163       163           
  Lines             6994      6994           
=============================================
  Hits              6994      6994           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/threshold/threshold_methods.py 100.00% <100.00%> (ø)

@nfahlgren nfahlgren merged commit 932bc11 into release-4.0 Jul 6, 2023
@nfahlgren nfahlgren deleted the release-4.0-call_threshold-max-val branch July 6, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants