remove max_val param from threshold.binary() #1210
Conversation
| @@ -48,7 +46,7 @@ def binary(gray_img, threshold, max_value, object_type="light"): | |||
| params.device += 1 | |||
|
|
|||
| # Threshold the image | |||
| bin_img = _call_threshold(gray_img, threshold, max_value, threshold_method, "_binary_threshold_") | |||
| bin_img = _call_threshold(gray_img, threshold, 255, threshold_method, "_binary_threshold_") | |||
There was a problem hiding this comment.
happy to update this to keep max_value as a variable here and set that to 255 above in the function if that's preferred
There was a problem hiding this comment.
Hmmm @nfahlgren do we want to remove the argument from the helper function too? I don't imagine we'd ever set it to anything else...
There was a problem hiding this comment.
Yeah I think removing it is fine
|
It looks like there's a build issue. I'm wondering if that's just a "rerun and it should be fine" situation, or somehow related to the fact that I made this pull request from a fork? |
|
Hi Mark, you were right, the CI pipeline failed to upload coverage results to CodeCov and that's why it showed as failing. I reran the analysis and it passed this time. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1210 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 163 163
Lines 6994 6994
=============================================
Hits 6994 6994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Describe your changes
Removes max_val param from the
threshold.binarymethodType of update
feature enhancement
Associated issues
Accomplishes 1 task in this ticket: #1194
Additional context
There are a few tests failing for me in the
release-4.0. After these changes, no new tests are failing.@HaleySchuhl @nfahlgren This morning I sent you both an email about potentially contributing to this project. Figured I'd just push a PR while I waited for a response. Please feel free to mark this up as much as you want to make sure I'm properly contributing.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md