-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create plot_extraction.md #9
base: main
Are you sure you want to change the base?
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
…lantcv-geospatial into plot_extraction
Code for extracting plots based on number of ranges, columns, length of alley and row length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super minor, but having the filename closely matching the function name will make things more searchable as this repository gets larger in the future. Therefore, I suggest changing the filename to "extract_plot.md" here and the function file to "extract_plot.py".
Generally, this PR is adding a few functions all under the aim of plot extraction, but do we only expect an end user to call the function "write_shapefile"? If so, we can consider making the syntax of the other functions similar to that used in "helper functions" in the main namespace (e.g. _calculate_grid
is a helper function of auto_grid
inside roi_methods.py
).
Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md