Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform points #10

Merged
merged 22 commits into from
Aug 27, 2024
Merged

Add transform points #10

merged 22 commits into from
Aug 27, 2024

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Aug 1, 2024

Describe your changes
Add a function to transform a set of points given a georeferenced shapefile/geojson and a spectral data image. The points get transformed to a usable numpy coordinate system.

Waiting on update to read_geotif (switch to PlantCV-data dataclass syntax) which adds the geo_transform trait, which is a requirement for the transformation algorithm.

Type of update
Is this a:

  • New feature
  • Merge in order (functions from the main plantcv repo)

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Aug 1, 2024

Here's the code health analysis summary for commits 8dea687..17cd6f4. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl requested a review from k034b363 August 26, 2024 19:22
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@k034b363 k034b363 merged commit e82daa2 into main Aug 27, 2024
5 checks passed
@k034b363 k034b363 deleted the add_transform_points branch August 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants