Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 napari extract and format data for naive bayes #34

Merged
merged 15 commits into from
Sep 20, 2024

Conversation

maliagehan
Copy link
Member

@maliagehan maliagehan commented Aug 20, 2024

Describe your changes
added function to extract color information and reformat to be compatible with naive bayes functions.

Type of update
Is this a:

  • New feature or feature enhancement
  • Update to documentation

Associated issues
#33

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

added function to extract rgb values and format it for use in naive bayes
documentation for napari naive bayes added
Copy link

deepsource-io bot commented Aug 20, 2024

Here's the code health analysis summary for commits e40c11b..b30f87a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@maliagehan maliagehan added merge in order Set of PRs that need to be merged sequentially ready to review Ready for code review labels Aug 20, 2024
ran naive bayes all the way through and realized that values that I thought were rgb were being reported as bgr. Reversed those to correct.
Base automatically changed from 30-napari-draw-mask to main September 13, 2024 19:46
@maliagehan maliagehan linked an issue Sep 13, 2024 that may be closed by this pull request
import numpy as np


def napari_naive_bayes_colors(img, maskdict, filename):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in future iterations, rename the parameter to rgb_img

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Napari PRs are now merged!

@HaleySchuhl HaleySchuhl merged commit 447f2ab into main Sep 20, 2024
5 checks passed
@HaleySchuhl HaleySchuhl deleted the 33-napari-extract-and-format-data-for-naive-bayes branch September 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge in order Set of PRs that need to be merged sequentially ready to review Ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Napari: Extract and format data for naive bayes
2 participants