30 napari draw mask #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napari points mask function.
added tests and napari_points_mask. Also fixed viewer.close() in napari open test.
realized that cv.circle drew pretty rough circles, so I changed it so that only squares are allowed as a shape option (thus removing the option) from all the functions
Added napari points mask docs
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
maliagehan
added
ready to review
missed a whitespace, deepsource is complaining about a protected class, I don't think there is a way around that since we're not going to change the napari code base.
fixing deepsource issue and adding class to get around protected class issue.
fixed docstring
reverting back to the other method of calling viewer
|
Tried to resolve the protected class issue by creating a subclass as Noah suggested, but the protect class deepsource issue just moved to the class, so we changed it back to the original method for simplicity, it doesn't seem like we can get around this without directly changing Napari. |
missing viewer.close() on test
…er/plantcv-annotate into 30-napari-draw-mask
remove shape param
remove shape param
remove shape param from label_classes
HaleySchuhl
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Altered the napari label points function so that only squares are accepted as a shape. This is because other shapes (circles are not drawn well with CV2) and the point of the function added in this pull request is to generate a mask of points so that data can be extracted from masks (for naive bayes for example)
Type of update
Is this a:
Associated issues
#30
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md