Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic functionality for annotating Points #3

Merged
merged 39 commits into from
Apr 22, 2024
Merged

add basic functionality for annotating Points #3

merged 39 commits into from
Apr 22, 2024

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Feb 29, 2024

Describe your changes
Add "point" annotation, ability to import and export (save out) collected point annotations, and plotting. Also ability to label different classes of annotations (e.g. pollenated vs un-pollenated) and save class counts.

Code originally added to this old branch danforthcenter/plantcv#754 but the PR became unruly and difficult to push forward with changes without breaking changes, so separated out to it's own repository here.

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added the work in progress Mark work in progress label Feb 29, 2024
Copy link

deepsource-io bot commented Feb 29, 2024

Here's the code health analysis summary for commits cfb9d5f..8ff04cc. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Feb 29, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@HaleySchuhl HaleySchuhl requested a review from maliagehan March 6, 2024 20:31
@HaleySchuhl HaleySchuhl added ready to review Ready for code review and removed work in progress Mark work in progress labels Mar 6, 2024
@HaleySchuhl
Copy link
Contributor Author

Currently, we have named the method to print text file .print_coords, and intend to have another method called .save_coords that talks to pcv.Outputs class (after the repo has been moved out and above the main plantcv repo). Names were selected based on other PlantCV functions and methods (print to file and save to outputs) but open to other ideas. We are allowing ourselves to make breaking changes as we see fit before doing a real conda version release.

Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add documentation later

@nfahlgren nfahlgren merged commit 3a0d074 into main Apr 22, 2024
5 checks passed
@nfahlgren nfahlgren deleted the add_points branch April 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review Ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants