Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import points/coords to Napari #29

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Import points/coords to Napari #29

merged 9 commits into from
Sep 12, 2024

Conversation

maliagehan
Copy link
Member

@maliagehan maliagehan commented May 16, 2024

Describe your changes
Updating the Napari Label function to allow the import of data. Also adding a few additional options to label to make it more usable. For example, size of the points and shape are now options that the user can control. Previously, this was hardcoded, but images of different resolution will need different annotation sizes. This was an update to documentation, not a new doc page.

Type of update
Is this a:

  • New feature or feature enhancement
  • Update to documentation

Associated issues
Reference associated issue numbers. Does this pull request close any issues?
#28

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

maliagehan added 6 commits May 9, 2024 13:10
updating napari label classes to allow import of data, also updating to allow size parameter and to change color instead of shape.
updating napari label classes to allow import of data, also updating to allow size parameter and to change color instead of shape.
added viewer close
adding all of the colors
updating documentation for napari_label
Copy link

deepsource-io bot commented May 16, 2024

Here's the code health analysis summary for commits 4324cdd..526fb46. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@maliagehan maliagehan added ready to review Ready for code review merge in order Set of PRs that need to be merged sequentially labels May 16, 2024
@maliagehan maliagehan linked an issue May 16, 2024 that may be closed by this pull request
Base automatically changed from 18-napari-import-data to main September 12, 2024 18:37
@maliagehan maliagehan linked an issue Sep 12, 2024 that may be closed by this pull request
@HaleySchuhl HaleySchuhl self-requested a review September 12, 2024 18:41
@HaleySchuhl HaleySchuhl merged commit 888e3db into main Sep 12, 2024
5 checks passed
@HaleySchuhl HaleySchuhl deleted the 18-napari-import-coor branch September 12, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge in order Set of PRs that need to be merged sequentially ready to review Ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Napari Function that Imports Data add size option to napari label for images of different resolution.
2 participants