Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Napari join labels #13

Merged
merged 56 commits into from
May 6, 2024
Merged

Napari join labels #13

merged 56 commits into from
May 6, 2024

Conversation

maliagehan
Copy link
Member

@maliagehan maliagehan commented Mar 27, 2024

Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.

Type of update
Is this a:

  • New feature or feature enhancement
  • Update to documentation

Associated issues
Reference associated issue numbers. Does this pull request close any issues? #12

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Made napari_label_classes more general, should work with all datatypes that napari_open can use although it might not make sense to label data in this way.
Made napari_label_classes more general, should work with all datatypes that napari_open can use although it might not make sense to label data in this way.
Copy link

deepsource-io bot commented Mar 27, 2024

Here's the code health analysis summary for commits 9fe576f..73ce255. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@maliagehan
Copy link
Member Author

maliagehan commented Apr 2, 2024

notebooks to test are available on workspace jupyter>pcv-annotate-prs>pr13-napari-join-labels. Sorry there are multiple functions. There is a notebook for each function for testing.

@maliagehan maliagehan added the ready to review Ready for code review label Apr 2, 2024
@maliagehan maliagehan removed the ready to review Ready for code review label Apr 11, 2024
@maliagehan
Copy link
Member Author

Realized by adding the printing option that I should save that out to a temp file in the test, will update that

realized that when I was testing debug param I accidentally added some images to the repo
@maliagehan maliagehan added the ready to review Ready for code review label Apr 12, 2024
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plantcv-annotate doesn't yet have an updating.md, so these changes would need to be added to that if it is created later. Notebook used for testing functionality stored in data_science/jupyter/pcv-annotate-prs/pr13-napari-join-labels/review_materials_KB/

@HaleySchuhl
Copy link
Contributor

I believe the changelog.md is serving the same purpose as updating.md in the add-on repositories, so we can add new functions there. And then once it's packaged up on Conda and/or pip then we might want to add a doc page for versioning.

@nfahlgren
Copy link
Member

I changed the name to changelog for the add-on packages because that's really what we use the updating page for. I don't think we need a separate page for versioning as we don't really use the existing page for that per se.

@nfahlgren nfahlgren merged commit c2ed906 into main May 6, 2024
5 checks passed
@nfahlgren nfahlgren deleted the napari-join-labels branch May 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review Ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants