-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Napari join labels #13
Conversation
Made napari_label_classes more general, should work with all datatypes that napari_open can use although it might not make sense to label data in this way.
Made napari_label_classes more general, should work with all datatypes that napari_open can use although it might not make sense to label data in this way.
…r/plantcv-annotate into napari-join-labels
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
deepsource fix
need to see where test coverage is missing.
fixed test
deepsource complexity fix
adjusted what the printed image looks like
notebooks to test are available on workspace jupyter>pcv-annotate-prs>pr13-napari-join-labels. Sorry there are multiple functions. There is a notebook for each function for testing. |
Realized by adding the printing option that I should save that out to a temp file in the test, will update that |
realized that when I was testing debug param I accidentally added some images to the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plantcv-annotate doesn't yet have an updating.md, so these changes would need to be added to that if it is created later. Notebook used for testing functionality stored in data_science/jupyter/pcv-annotate-prs/pr13-napari-join-labels/review_materials_KB/
I believe the |
I changed the name to |
Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues? #12
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md