Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Points.correct methods #11

Closed
wants to merge 25 commits into from
Closed

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Mar 15, 2024

Describe your changes
Add .correct and .correct_label methods to Points class.

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Goal implementation

  • update .correct to add/remove objects to the binary mask without changing the shape of any objects (makes application more generalizable)
  • don't update coordinates with correction, hand annotations are ground truth and correction maintains annotations that cannot be resolved algorithmically)
  • .correct_labels can only allow class_label addition with different labels

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Mar 15, 2024

Here's the code health analysis summary for commits c2ed906..687ee7c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage❌ Failure
❗ 3 occurences introduced
View Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage94.8% (down 5.2% from main)94.8% (down 5.2% from main)
Line Coverage94.8% (down 5.2% from main)94.8% (down 5.2% from main)
New Branch Coverage100%100%
New Composite Coverage84.8%84.8%
New Line Coverage84.8%84.8%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl added the work in progress Mark work in progress label Mar 15, 2024
@HaleySchuhl HaleySchuhl changed the title Add correction methods Add Points.correct methods Mar 15, 2024
@HaleySchuhl HaleySchuhl self-assigned this Mar 15, 2024
@HaleySchuhl HaleySchuhl removed the work in progress Mark work in progress label Jun 3, 2024
@HaleySchuhl
Copy link
Contributor Author

new algorithm in #27 instead

@HaleySchuhl HaleySchuhl closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant