Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

000458/FlatironInstitute #101

Merged
merged 6 commits into from
Sep 5, 2024
Merged

000458/FlatironInstitute #101

merged 6 commits into from
Sep 5, 2024

Conversation

magland
Copy link
Contributor

@magland magland commented Aug 31, 2024

Adds 000458/FlatironInstitute

It goes along with this blog post to show how to use Neurosift to explore the PSTH plots for this Dandiset.

Includes:

Also includes 000_lindi_vs_fsspec_streaming.ipynb to motivate why lindi is used instead of fsspec for streaming the NWB files.

@pauladkisson @bendichter @h-mayorquin

Copy link
Contributor

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I just made a few small suggestions

000458/FlatironInstitute/PSTH_neurosift_exploration.md Outdated Show resolved Hide resolved
000458/FlatironInstitute/PSTH_neurosift_exploration.md Outdated Show resolved Hide resolved
000458/FlatironInstitute/001_summarize_contents.ipynb Outdated Show resolved Hide resolved
@magland
Copy link
Contributor Author

magland commented Sep 2, 2024

Thanks @pauladkisson I committed those changes.

Copy link
Contributor

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, looks good!

@magland
Copy link
Contributor Author

magland commented Sep 5, 2024

@yarikoptic can this be merged?

@yarikoptic
Copy link
Member

fix the typo?

Error: ./000458/FlatironInstitute/001_summarize_contents.ipynb:18: Supress ==> Suppress

meanwhile let's checkout the content...

"source": [
"# This notebook compares the time taken to stream an NWB file from DANDI archive\n",
"# using lindi and fsspec. On my laptop on my home WiFi network, lindi streaming\n",
"# took 7.52 s and fsspec streaming took 141.01 s. This is expected to depend\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance to add timing comparison to your nwb-tuned alternative to fsspec for a more frank comparison? ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect lindi to be about the same as remfile, but I'm moving toward using lindi for everything since it has benefits beyond just this streaming. The purpose here is not to do a rigorous comparison between the methods, it's just to motivate why I'm not using fsspec, which seems to be the standard recommended method in all the docs still. So I'd prefer not to also include remfile here.

white circle: 316 valid and not running
ESTIM TARGET REGIONS
MOs: 1103 valid and not running
n/a: 316 valid and not running
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, could have that script could have (optionally?) produced markdown with neurosift URLs pointing to those particular files/settings in neurosift to select the desired trials? or URL would be a bit unruly to create and fragile (might change in the future)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. It's now markdown with links to NS. Not as fancy as the settings as you suggest, but it gets you to the file.

- ipykernel
- matplotlib
- lindi==0.4.0a1
- fsspec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if might be worth to version all of them to guarantee reproducibility/reliable operation (eventually dandi or pynwb api could break etc)? or may be provide complimentary environment-frozen.yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the versions

@yarikoptic
Copy link
Member

besides the typo looks great to me and I verified that .md instructions work as described! Left some ideas, but in general after typo is fixed IMHO could be merged.

@magland
Copy link
Contributor Author

magland commented Sep 5, 2024

besides the typo looks great to me and I verified that .md instructions work as described! Left some ideas, but in general after typo is fixed IMHO could be merged.

Thanks @yarikoptic I made the updates.

@yarikoptic yarikoptic merged commit 315e553 into dandi:master Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants