Reduce messaging to pyout on progress of downloads #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
requested changes
Dec 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 88.49% 88.52% +0.03%
==========================================
Files 78 78
Lines 10742 10736 -6
==========================================
- Hits 9506 9504 -2
+ Misses 1236 1232 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r file or when done This is primarily to resolve the problem of pyout "dragging us behind" which slows down entire download process. #1549
…sted here/before logic Now, that to filter out some progress records we rely on having "done%" reported, reflect that we are reportint it for final records
OPT: this avoids 2nd loop (after Counter) over the .files in .messge property which was used only to report stats anyways. This could be notable while reporting on a zarr with 100_000 or more files
For that exception we did get logged:
❯ grep Assertion /home/yoh/.local/state/dandi-cli/log/2024.12.16*
/home/yoh/.local/state/dandi-cli/log/2024.12.16-15.24.12Z-119733.log:AssertionError: attempts_allowed_or_not is None of type <class 'NoneType'>
which makes little sense (besides some thread unsafe handling or None becoming
bool(True))). To overcome and avoid need for assert, just fold that
condition directly into "if" statement.
yarikoptic
force-pushed
the
rf-pyoutefficiency
branch
from
f5b58d2 to
2f74075
Compare
jwodder
approved these changes
Dec 17, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to help with
Also includes small tune up for summary over messages