download: provide description for an assertion error on attempts_allowed_or_not #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, with some prior version of the code, but we did get this assertion triggered as shown in #1549 (comment) although it remains unclear how that could have happened if type checking is correct since we must not end up there with None or even 0. Unfortunately with a regular assert we just get an announcement of the fact and no details. After this change we hope to be able to see more details which might hint on the original issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 88.44% 88.56% +0.12%
==========================================
Files 78 78
Lines 10742 10742
==========================================
+ Hits 9501 9514 +13
+ Misses 1241 1228 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jwodder
approved these changes
Dec 11, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, with some prior version of the code, but we did get this assertion triggered as shown in
#1549 (comment) although it remains unclear how that could have happened if type checking is correct since we must not end up there with None or even 0.
Unfortunately with a regular assert we just get an announcement of the fact and no details. After this change we hope to be able to see more details which might hint on the original issue.