BF: do allow for user to specify a proper full name for "species" in metadata #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
added
patch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
+ Coverage 88.40% 88.56% +0.16%
==========================================
Files 78 78
Lines 10737 10742 +5
==========================================
+ Hits 9492 9514 +22
+ Misses 1245 1228 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks like that there are a couple of tests failing that are related to these changes. |
…metadata Apparently before we were checking for URLs and only for "common names", not proper long names. It is susprising that the problem manifested only now then! Addressing user report on Slack
yarikoptic
force-pushed
the
bf-species
branch
from
07fe80f to
33903e7
Compare
|
d'oh -- I should get into a habit of running type checks before pushing ;) should be resolved now. But I still wonder how come we run into this just now??? |
kabilar
approved these changes
Dec 4, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing user report on Slack.
Apparently (thus checking with @satra) we were checking for URLs and only for "common names", not proper long names. It is surprising that the problem manifested only now then!